[llvm] r178854 - Buildbot fix for r178851: mistake was in wrong TargetRegisterInfo::getRegClass usage.
Stepan Dyatkovskiy
stpworld at narod.ru
Wed Apr 17 08:30:20 PDT 2013
Hi All,
I'm glad to report that my beagleboard finished test-suite :-)
I've launched tests for r179536 and for r179536 + my patch. Each test
took 21 hours and 30 mins :-)
Tests have finished with same results. I don't know which failures are
exepected and which are not.
I attached list of r179536 failures. With my patch the list of failures
remains the same.
I've also reattached patch, that fixed pr14824.
-Stepan.
Renato Golin wrote:
> Hi Stepan,
>
> You are right, the test remained broken until I cleaned the directory.
> However, after Jakob's enquires, I think we should still keep it off
> until another round of review is done. Shouldn't be a problem, since the
> patch is localized and doesn't depend on APIs that change too often.
>
> If Jacob is happy with your patch, I'm fine with it as long as it passes
> at least check-all and test-suite on an A8 or higher and on x86_64.
>
> cheers,
> --renato
>
>
> On 7 April 2013 12:51, Stepan Dyatkovskiy <stpworld at narod.ru
> <mailto:stpworld at narod.ru>> wrote:
>
> Hi,
> Eh.. guys, I looked at clang-native-arm-lnt after my patch was reverted,
> Revert of r178854 didn't fix any of failed tests, revision number of
> revert commit is 178883. In #452 build (r178904) it is still failed
> (few hours after Renato reverted my commits). Actually it have been
> fixed somewhere between 178904 and 178923).
>
> But I'm still very sorry about ugly r178851 and *absent* reaction
> after 178854. Currently my beagleboard rebuilds everything, so I'll
> publish test reports soon.
>
> I also have question about
> TargetRegisterInfo::__getMinimalPhysRegClass and
> QPRRegClass.contains(). My purpose in this code is to find the
> minimal class for register. I supposed this method does exactly what
> I need.
> So do you propose to replace it with
> SPRRegClass/DPRRegClass/__QPRRegClass.contains methods set?
>
> -Stepan.
>
>
> Jakob Stoklund Olesen wrote:
>
>
> On Apr 5, 2013, at 11:36 AM, Renato Golin
> <renato.golin at linaro.org <mailto:renato.golin at linaro.org>> wrote:
>
> On 5 April 2013 19:26, Jakob Stoklund Olesen
> <stoklund at 2pi.dk <mailto:stoklund at 2pi.dk>> wrote:
>
> That's not right either. How are you testing this code?
> Please don't just guess.
>
> You should probably be using QPRRegClass.contains().
>
> Hi Jacob,
>
> I have reverted this (and the original) patch already. This
> is not right and there isn't enough tests to make me sleep
> at night.
>
> Unless I see clear evidence that a patch in that area is
> actually doing what it should (via review of someone that
> knows it, like you) AND proper tests are passing (including
> the test-suite on ARM), it'll remain reverted.
>
>
> Thanks, Renato.
>
> I agree.
>
> /jakob
>
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr14824-test-suite-report.tgz
Type: application/x-gtar-compressed
Size: 24833 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130417/2b9b5145/attachment.tgz>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr14824-2013-04-10.patch
Type: text/x-diff
Size: 8617 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130417/2b9b5145/attachment.patch>
-------------- next part --------------
Program | GCCAS Bytecode LLC compile LLC-BETA compile JIT codegen | GCC LLC LLC-BETA JIT | GCC/LLC GCC/LLC-BETA LLC/LLC-BETA
MultiSource/Applications/hbd/hbd | 0.1875 121280 * * * | 0.0312 * * * | n/a n/a n/a
MultiSource/Applications/hexxagon/hexxagon | 0.0703 58152 * * * | 73.2266 * * * | n/a n/a n/a
MultiSource/Applications/kimwitu++/kc | * * * * * | 0.6016 * * * | n/a n/a n/a
MultiSource/Applications/spiff/spiff | 0.5156 77268 * * * | 53.9844 * * * | n/a n/a n/a
MultiSource/Benchmarks/MallocBench/gs/gs | 1.3906 494020 * * * | 95.7422 * * * | n/a n/a n/a
MultiSource/Benchmarks/NPB-serial/is/is | 0.0781 6996 * * * | 136.9531 * * * | n/a n/a n/a
MultiSource/Benchmarks/Olden/voronoi/voronoi | 0.0469 26352 * * * | 6.1094 * * * | n/a n/a n/a
MultiSource/Benchmarks/PAQ8p/paq8p | 0.6797 313996 * * * | 0.0078 * * * | n/a n/a n/a
MultiSource/Benchmarks/SciMark2-C/scimark2 | 0.0391 18676 * * * | 499.2656 * * * | n/a n/a n/a
MultiSource/Benchmarks/TSVC/ControlFlow-dbl/ControlFlow-dbl | 0.2578 83796 * * * | 499.1016 * * * | n/a n/a n/a
MultiSource/Benchmarks/TSVC/ControlFlow-flt/ControlFlow-flt | 0.5859 84236 * * * | 387.3594 * * * | n/a n/a n/a
MultiSource/Benchmarks/TSVC/NodeSplitting-dbl/NodeSplitting-dbl | 0.2344 73028 * * * | 499.1172 * * * | n/a n/a n/a
MultiSource/Benchmarks/mafft/pairlocalalign | 1.5391 436824 * * * | 497.8750 * * * | n/a n/a n/a
MultiSource/Benchmarks/tramp3d-v4/tramp3d-v4 | * * * * * | 10.1328 * * * | n/a n/a n/a
SingleSource/Benchmarks/CoyoteBench/fftbench | * * * * * | 28.7500 * * * | n/a n/a n/a
SingleSource/Benchmarks/Misc-C++-EH/spirit | 1.4922 729768 * * * | 43.6328 * * * | n/a n/a n/a
SingleSource/Benchmarks/Misc-C++/bigfib | * * * * * | 2.9062 * * * | n/a n/a n/a
SingleSource/Benchmarks/Polybench/linear-algebra/kernels/3mm/3mm | 0.0156 5800 * * * | 997.4922 * * * | n/a n/a n/a
SingleSource/Benchmarks/Polybench/linear-algebra/kernels/symm/symm | 0.0078 4060 * * * | 499.2031 * * * | n/a n/a n/a
SingleSource/Benchmarks/Shootout-C++/EH/except | 0.0078 5100 * * * | 1.6719 * * * | n/a n/a n/a
SingleSource/Benchmarks/Shootout-C++/reversefile | * * * * * | 0.0000 * * * | n/a n/a n/a
SingleSource/Benchmarks/Shootout-C++/strcat | * * * * * | 0.9922 * * * | n/a n/a n/a
SingleSource/Regression/C++/EH/ctor_dtor_count | 0.0000 1824 * * * | 0.0000 * * * | n/a n/a n/a
SingleSource/Regression/C++/EH/ctor_dtor_count-2 | 0.0078 2324 * * * | 0.0000 * * * | n/a n/a n/a
SingleSource/Regression/C++/EH/exception_spec_test | 0.0078 3820 * * * | 0.0000 * * * | n/a n/a n/a
SingleSource/Regression/C++/EH/function_try_block | 0.0078 3620 * * * | 0.0000 * * * | n/a n/a n/a
SingleSource/Regression/C++/EH/inlined_cleanup | 0.0000 1744 * * * | 0.0000 * * * | n/a n/a n/a
SingleSource/Regression/C++/EH/recursive-throw | 0.0000 2684 * * * | 0.0000 * * * | n/a n/a n/a
SingleSource/Regression/C++/EH/simple_rethrow | 0.0000 2460 * * * | 0.0078 * * * | n/a n/a n/a
SingleSource/Regression/C++/EH/simple_throw | 0.0000 1292 * * * | 0.0000 * * * | n/a n/a n/a
SingleSource/Regression/C++/EH/throw_rethrow_test | 0.0078 2672 * * * | 0.0000 * * * | n/a n/a n/a
More information about the llvm-commits
mailing list