[PATCH] Do not optimise fprintf() calls if its return value is used.
Peter Collingbourne
peter at pcc.me.uk
Tue Apr 16 19:02:56 PDT 2013
On Mon, Apr 08, 2013 at 11:25:29AM -0500, Meador Inge wrote:
> On 04/03/2013 05:10 PM, Peter Collingbourne wrote:
>
> > http://llvm-reviews.chandlerc.com/D620
> >
> > Files:
> > lib/Transforms/Utils/SimplifyLibCalls.cpp
> > test/Transforms/InstCombine/fprintf-1.ll
>
> This patch is OK. Thanks for fixing it.
r179661.
> I know we have similar logic in place for the printf simplifiers.
> Did you audit the code to see if we have other return value use
> bugs?
No, I only fixed this one specific bug I found. But I found it
using glibc's test suite which I hope is somewhat comprehensive.
Thanks,
--
Peter
More information about the llvm-commits
mailing list