[PATCH] Change internal allocator in sanitizer tools

Alexey Samsonov samsonov at google.com
Tue Apr 16 05:11:29 PDT 2013



================
Comment at: lib/sanitizer_common/sanitizer_allocator.cc:20
@@ +19,3 @@
+#if SANITIZER_WORDSIZE == 64
+static const uptr kInternalAllocatorSpace = 0x690000000000ULL;
+static const uptr kInternalAllocatorSize =   0x10000000000ULL;  // 1T
----------------
Dmitry Vyukov wrote:
> THis won't work on windows (for gotsan). windows address space is 43-bit.
ok... I glanced at tsan_platform.h for Go-Windows and couldn't find a place for yet another mapping...

================
Comment at: lib/sanitizer_common/tests/sanitizer_allocator_test.cc:585
@@ +584,3 @@
+  u64 end = space + size;
+  CHECK_LE(end, (SANITIZER_WORDSIZE == 64) ? 0x800000000000ULL
+                                           : 0x100000000ULL);
----------------
Evgeniy Stepanov wrote:
> I'd prefer if (SANITIZER_WORDSIZE == 64) {
> all-checks-for-64-bits
> } else {
> all-checks-for-32-bits
> }
Done


http://llvm-reviews.chandlerc.com/D671



More information about the llvm-commits mailing list