R600: Emit natively encoded TEX/VTX instructions

[Tobias Grosser]

On 04/15/2013 06:36 PM, Vincent Lejeune wrote:
> ----- Mail original -----
>> De : Tobias Grosser <tobias at grosser.es>
>> À : Vincent Lejeune <vljn at ovi.com>
>> Cc : "llvm-commits at cs.uiuc.edu" <llvm-commits at cs.uiuc.edu>
>> Envoyé le : Lundi 15 avril 2013 18h13
>> Objet : Re: R600: Emit natively encoded TEX/VTX instructions
>>
>> On 04/15/2013 05:22 PM, Vincent Lejeune wrote:
>>>   Hi,
>>>
>>>   This set of 3 patches enables LLVm to emit hw instructions for TEX/VTX
>> clause (it previously emitted intermediate instructions
>>>   that were preprocessed by Mesa).
>>
>> I only see one tiny test case. Did you forgot the other test cases or is
>> there no good way to write tests for the other changes?
>>
>> Tobias
>>
>
> I didn't find a good way to test the others change ; TEX/VTX is a gpu specific thing (it fetch texture data from video memory)
> and are better tested inside an opengl or opencl stack. For this we use piglit (10 000+ opengl tests), for lit test I can only
> think of test that would check that clause content is never before a cf_end/cf_nop but such bug are immediately spotted by
> piglit (the test would lock your computer).

As discussed previously, piglit tests are not run by the general LLVM 
developer. In the absence of any even the most trivial lit test, there 
is no way for a non r600 developer to check if he may have introduced a 
bug in your back-end.

It would be great to follow Christian Koenig here:

"I think the only way out of this misery is that I promise to either 
provide a test case or a very very good reason not to do so for future 
patches."

Cheers,
Tobi