[PATCH][llvm-c] GlobalVariable: Expose ThreadLocalMode and ExternallyInitialized

Hans Wennborg hans at chromium.org
Mon Apr 15 02:19:18 PDT 2013


Hi Moritz,

On Wed, Apr 3, 2013 at 8:25 PM, Moritz Maxeiner
<moritzmaxeiner at googlemail.com> wrote:
> Add four new functions and one new enum to the C API:
>
> LLVMGetThreadLocalMode - exposes GlobalVariable::getThreadLocalMode
> LLVMSetThreadLocalMode - exposes GlobalVariable::setThreadLocalMode
> LLVMIsExternallyInitialized - exposes
> GlobalVariable::isExternallyInitialized
> LLVMSetExternallyInitialized - exposes
> GlobalVariable::setExternallyInitialized
> LLVMThreadLocalMode - maps to GlobalVariable::ThreadLocalMode

I think this looks good in general.

Just wondering, in the interest of keeping the C API simple and
stable, would it be enough to expose just something like
LLVMIsThreadLocal / LLVMSetThreadLocal, or do you actually need the
full enum?

Thanks,
Hans



More information about the llvm-commits mailing list