[PATCH] MC: Support larger COFF string tables

Anton Korobeynikov anton at korobeynikov.info
Mon Apr 15 01:39:03 PDT 2013


  I'd suggest asking Michael about this patch as well.


================
Comment at: lib/MC/WinCOFFObjectWriter.cpp:474
@@ +473,3 @@
+static void encodeBase64StringEntry(char* Buffer, uint64_t Value)
+{
+  assert(Value > 9999999 && Value <= 0xFFFFFFFFF &&
----------------
The brace definitely should be on other line. Same for other code below.

================
Comment at: lib/MC/WinCOFFObjectWriter.cpp:486
@@ +485,3 @@
+  char* Ptr = Buffer + 7;
+  for (int i = 0; i < 6; ++i) {
+    unsigned Rem = Value % 64;
----------------
Why int? Was this code copied from somewhere else verbatim?


http://llvm-reviews.chandlerc.com/D667



More information about the llvm-commits mailing list