[PATCH] Add support for subsections to the ELF assembler. Fixes PR8717.

Peter Collingbourne peter at pcc.me.uk
Sun Apr 14 14:47:33 PDT 2013


On Sun, Apr 14, 2013 at 02:38:39PM -0400, Rafael EspĂ­ndola wrote:
> > We would in fact need two parameters (the fragment list and the
> > insertion point), as we won't necessarily be able to derive the
> > fragment list from the insertion point if it's at the end.
> 
> Can't you pass the insertion point with the semantics of "insert after this"?

What if the list is empty?

> > There are also a few places in ELFObjectWriter where we do
> > need to create unparented MCFragments.
> >
> 
> I don't think so, check r179124.

OK, I stand corrected.  I must have misread something.

Thanks,
-- 
Peter



More information about the llvm-commits mailing list