[PATCH] Correct printing of pre-indexed operands

[Mihail Popa]

Hi Quentin.

It's just (intended) trimming of extra white space at the end of the line.

Regards,
Mihai
________________________________________
From: Quentin Colombet [qcolombet at apple.com]
Sent: Friday, April 12, 2013 5:42 PM
To: Mihail Popa
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [PATCH] Correct printing of pre-indexed operands

Hi Mihai,

At the very end of your patch it seems you have unintended changes:
-      << markup("<imm:")
+      << markup("<imm:”)
and
-      << markup("<imm:")
+      << markup("<imm:")

Other than that LGTM.

Thanks

-Quentin

On Apr 12, 2013, at 9:29 AM, Mihail Popa <Mihail.Popa at arm.com<mailto:Mihail.Popa at arm.com>> wrote:

Hi.

According to the ARM reference manual, constant offsets are mandatory for pre-indexed addressing modes. Currently the MC disassembler
does not obey this when the offset is 0. It produces instructions like: str r0, [r1]!. Correct syntax is: str r0, [r1, #0]!.

This change modifies the dumping of operands so that the offset is always printed, regardless of its value, when pre-indexed addressing mode
is used.

Patch attached for review.

Thanks,
Mihai

-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.<LLVM-707.preindex.patch>_______________________________________________
llvm-commits mailing list
llvm-commits at cs.uiuc.edu<mailto:llvm-commits at cs.uiuc.edu>
http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits


-- IMPORTANT NOTICE: The contents of this email and any attachments are confidential and may also be privileged. If you are not the intended recipient, please notify the sender immediately and do not disclose the contents to any other person, use it for any purpose, or store or copy the information in any medium.  Thank you.