[llvm] r178541 - Simplify test cases for Atom preferring call register indirect over

[Gurd, Preston]

Thanks, Eli. Fixed by r179322.

Preston

From: Eli Bendersky [mailto:eliben at google.com]
Sent: Thursday, April 11, 2013 12:32 PM
To: Gurd, Preston
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm] r178541 - Simplify test cases for Atom preferring call register indirect over


Modified:
    llvm/trunk/test/CodeGen/X86/atom-call-reg-indirect-foldedreload32.ll
    llvm/trunk/test/CodeGen/X86/atom-call-reg-indirect-foldedreload64.ll

Modified: llvm/trunk/test/CodeGen/X86/atom-call-reg-indirect-foldedreload32.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/atom-call-reg-indirect-foldedreload32.ll?rev=178541&r1=178540&r2=178541&view=diff
==============================================================================
--- llvm/trunk/test/CodeGen/X86/atom-call-reg-indirect-foldedreload32.ll (original)
+++ llvm/trunk/test/CodeGen/X86/atom-call-reg-indirect-foldedreload32.ll Tue Apr  2 09:25:06 2013
@@ -1,204 +1,77 @@
 ; RUN: llc < %s -mtriple=i386-linux-gnu -mcpu=atom 2>&1 | \
 ; RUN:     grep "calll" | not grep "("
 ; RUN: llc < %s -mtriple=i386-linux-gnu -mcpu=core2 2>&1 | \
-; RUN:     grep "calll" | grep "4-byte Folded Reload"
+; RUN:     grep "calll" | grep "*funcp"
+;


Preston, please don't add new tests with 'grep', use 'FileCheck' instead. Note this paragraph from the testing guide (http://llvm.org/docs/TestingGuide.html):

    The recommended way to examine output to figure out if the test passes is using the FileCheck tool<http://llvm.org/docs/CommandGuide/FileCheck.html>. [The usage of    grep in RUN lines is deprecated - please do not send or commit patches that use it.]

Thanks in advance,
Eli


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130411/2001790b/attachment.html>