[PATCH] [sanitizer] Syscall hooks

Alexander Potapenko glider at google.com
Thu Apr 11 06:42:21 PDT 2013



================
Comment at: lib/msan/lit_tests/Linux/syscalls.cc:19
@@ +18,3 @@
+  __sanitizer_syscall_pre_rt_sigpending((void *)buf, 10);
+  __sanitizer_syscall_pre_getdents(0, (struct sanitizer_kernel_dirent *)buf,
+                                   10);
----------------
Can we please have consistent argument wrapping in the whole file?
For such long function names it should be better to write all the parameters on the next line.

================
Comment at: lib/sanitizer_common/sanitizer_common_syscalls.inc:112
@@ +111,3 @@
+
+}
+
----------------
Alexey Samsonov wrote:
> }  // extern "C"
}  // extern "C"

================
Comment at: lib/msan/lit_tests/Linux/syscalls.cc:13
@@ +12,3 @@
+
+int main(int argc, char *argv[]) {
+  char buf[1000];
----------------
A small comment about what you're actually testing here, please.
E.g. the presence of certain _pre_ and _post_ functions, the validity of shadow.


http://llvm-reviews.chandlerc.com/D655



More information about the llvm-commits mailing list