[patch] add function for system argument limit checking

Nathan Froyd nfroyd at mozilla.com
Wed Apr 10 13:23:35 PDT 2013


On Wed, Apr 10, 2013 at 02:52:06PM -0400, Rafael EspĂ­ndola wrote:
> LGTM. The only nit is that the argument name should start with an
> uppercase (Args).

Fixed in the attached patch.

> Since this is for use in clang, lets test it there.

OK.  I haven't worked out how to test this in a platform-independent
manner; if you have ideas, I'd be interested in hearing them.

> Do you want me to commit this? Depending on how much work you expect
> to do you might want to ask for commit access.

Please commit it for me.  I'll ask for commit access if/when having
other people commit patches becomes a burden.

Thanks,
-Nathan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: arguments-system-limit.patch
Type: text/x-diff
Size: 2497 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130410/47e0fdb8/attachment.patch>


More information about the llvm-commits mailing list