[llvm] r179135 - Mips specific inline asm operand modifier 'D'
Jack Carter
Jack.Carter at imgtec.com
Tue Apr 9 21:14:01 PDT 2013
Eric,
I'm a bit confused, but want to do the right thing.
I thought I had to package a succinct .ll test case and not a full C program. That is what I did.
Adding this test case, reformatted of course, to the clang suite is clear.
Cleaning up the attributes is clear.
But do you mean for me to replace the current test/CodeGen/Mips/inlineasmmemop.ll which tests for the 2 cases?
If so, That's what I will do.
I included the C test to give folks a clue as to what I was talking about.
Cheers,
Jack
________________________________________
From: Eric Christopher [echristo at gmail.com]
Sent: Tuesday, April 09, 2013 4:57 PM
To: Jack Carter
Cc: llvm-commits at cs.uiuc.edu
Subject: Re: [llvm] r179135 - Mips specific inline asm operand modifier 'D'
> #include "stdio.h"
>
> int b[8] = {0,1,2,3,4,5,6,7};
> void main()
> {
> int i;
>
> // The first word. Notice, no 'D'
> {asm (
> "lw %0,%1;"
> : "=r" (i)
> : "m" (*(b+4))
> );}
>
> printf("%d\n",i);
>
> // The second word
> {asm (
> "lw %0,%D1;"
> : "=r" (i)
> : "m" (*(b+4))
> );}
>
> printf("%d\n",i);
> }
>
Please put this code in the test, but hopefully a bit better formatted :)
A front end test might be good as well?
> +
> +attributes #0 = { nounwind "less-precise-fpmad"="false" "no-frame-pointer-elim"="true" "no-frame-pointer-elim-non-leaf"="true" "no-infs-fp-math"="false" "no-nans-fp-math"="false" "unsafe-fp-math"="false" "use-soft-float"="false" }
And clean up the attributes here.
Thanks!
-eric
More information about the llvm-commits
mailing list