[llvm] r179120 - Revert r179115 as it looks to have killed the ASan tests.
Chad Rosier
mcrosier at apple.com
Tue Apr 9 12:59:13 PDT 2013
Author: mcrosier
Date: Tue Apr 9 14:59:12 2013
New Revision: 179120
URL: http://llvm.org/viewvc/llvm-project?rev=179120&view=rev
Log:
Revert r179115 as it looks to have killed the ASan tests.
Modified:
llvm/trunk/include/llvm/MC/MCParser/MCAsmParser.h
llvm/trunk/lib/MC/MCParser/AsmParser.cpp
llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp
Modified: llvm/trunk/include/llvm/MC/MCParser/MCAsmParser.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/MC/MCParser/MCAsmParser.h?rev=179120&r1=179119&r2=179120&view=diff
==============================================================================
--- llvm/trunk/include/llvm/MC/MCParser/MCAsmParser.h (original)
+++ llvm/trunk/include/llvm/MC/MCParser/MCAsmParser.h Tue Apr 9 14:59:12 2013
@@ -151,13 +151,6 @@ public:
virtual bool parseExpression(const MCExpr *&Res, SMLoc &EndLoc) = 0;
bool parseExpression(const MCExpr *&Res);
- /// parsePrimaryExpr - Parse a primary expression.
- ///
- /// @param Res - The value of the expression. The result is undefined
- /// on error.
- /// @result - False on success.
- virtual bool parsePrimaryExpr(const MCExpr *&Res, SMLoc &EndLoc) = 0;
-
/// parseParenExpression - Parse an arbitrary expression, assuming that an
/// initial '(' has already been consumed.
///
Modified: llvm/trunk/lib/MC/MCParser/AsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/MC/MCParser/AsmParser.cpp?rev=179120&r1=179119&r2=179120&view=diff
==============================================================================
--- llvm/trunk/lib/MC/MCParser/AsmParser.cpp (original)
+++ llvm/trunk/lib/MC/MCParser/AsmParser.cpp Tue Apr 9 14:59:12 2013
@@ -221,7 +221,6 @@ public:
bool parseExpression(const MCExpr *&Res);
virtual bool parseExpression(const MCExpr *&Res, SMLoc &EndLoc);
- virtual bool parsePrimaryExpr(const MCExpr *&Res, SMLoc &EndLoc);
virtual bool parseParenExpression(const MCExpr *&Res, SMLoc &EndLoc);
virtual bool parseAbsoluteExpression(int64_t &Res);
@@ -870,10 +869,6 @@ bool AsmParser::parseExpression(const MC
return parseExpression(Res, EndLoc);
}
-bool AsmParser::parsePrimaryExpr(const MCExpr *&Res, SMLoc &EndLoc) {
- return ParsePrimaryExpr(Res, EndLoc);
-}
-
const MCExpr *
AsmParser::ApplyModifierToExpr(const MCExpr *E,
MCSymbolRefExpr::VariantKind Variant) {
Modified: llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp?rev=179120&r1=179119&r2=179120&view=diff
==============================================================================
--- llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp (original)
+++ llvm/trunk/lib/Target/X86/AsmParser/X86AsmParser.cpp Tue Apr 9 14:59:12 2013
@@ -1130,7 +1130,7 @@ X86Operand *X86AsmParser::ParseIntelBrac
if (ParseRegister(TmpReg, Start, End)) {
const MCExpr *Disp;
SMLoc IdentStart = Tok.getLoc();
- if (getParser().parsePrimaryExpr(Disp, End))
+ if (getParser().parseExpression(Disp, End))
return 0;
if (X86Operand *Err = ParseIntelVarWithQualifier(Disp, IdentStart))
@@ -1182,7 +1182,7 @@ X86Operand *X86AsmParser::ParseIntelBrac
SM.onRegister(TmpReg);
UpdateLocLex = false;
break;
- } else if (!getParser().parsePrimaryExpr(Disp, End)) {
+ } else if (!getParser().parseExpression(Disp, End)) {
SM.onDispExpr();
UpdateLocLex = false;
break;
@@ -1324,7 +1324,7 @@ X86Operand *X86AsmParser::ParseIntelMemO
const MCExpr *Disp = 0;
SMLoc IdentStart = Tok.getLoc();
- if (getParser().parsePrimaryExpr(Disp, End))
+ if (getParser().parseExpression(Disp, End))
return 0;
if (!isParsingInlineAsm())
@@ -1401,7 +1401,7 @@ X86Operand *X86AsmParser::ParseIntelOffs
SMLoc End;
const MCExpr *Val;
- if (getParser().parsePrimaryExpr(Val, End))
+ if (getParser().parseExpression(Val, End))
return ErrorOperand(Start, "Unable to parse expression!");
// Don't emit the offset operator.
@@ -1437,7 +1437,7 @@ X86Operand *X86AsmParser::ParseIntelOper
SMLoc End;
const MCExpr *Val;
- if (getParser().parsePrimaryExpr(Val, End))
+ if (getParser().parseExpression(Val, End))
return 0;
unsigned Length = 0, Size = 0, Type = 0;
More information about the llvm-commits
mailing list