[PATCH] fpcmp fix (wrt sqlite3)

[Renato Golin]

Thanks both of you! ;)

Committed in 178957.

cheers,
--renato


On 6 April 2013 17:40, Daniel Dunbar <daniel at zuster.org> wrote:

> LGTM, thanks for fixing it up!
>
>  - Daniel
>
>
> On Thu, Apr 4, 2013 at 5:20 PM, Renato Golin <renato.golin at linaro.org>wrote:
>
>> On 5 April 2013 00:57, Renato Golin <renato.golin at linaro.org> wrote:
>>
>>> I'll share my results once they're done, and while that, the test-suite
>>> is running with the new fpcmp.
>>>
>>
>> Patch attached. Whole test-suite pass (voronoi still fails, as before,
>> unrelated).
>>
>> Some simple extra tests:
>>
>> 1.31231312,3
>> 1.3123131,3
>> Old: would compare 1.31231312 with 3 and fail
>> New, as expected: e-7 pass, e-8 fails
>>
>> 1231.23123123
>> 123.123123123
>> Both behave well
>>
>> 421.41414abcdef
>> 421.4141411abcdef
>> Old: FP Comparison failed, not a numeric difference between 'a' and '4'
>> New, as expected: e-8 pass, e-9 fails
>>
>> lalala 123foo
>> lalala123foo
>> Both behave well
>>
>> 31,312.312
>> 31,312.31
>> At the end of a file.
>> Old, as expected, not a numeric difference between '' and '3'
>> New, as expected, reports the error e-6 and beyond
>>
>> cheers,
>> --renato
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130406/686018d9/attachment.html>