[llvm] r178845 - Fix bug in PEI's virtual-register scavenging

[Hal Finkel]

----- Original Message -----
> From: "Krzysztof Parzyszek" <kparzysz at codeaurora.org>
> To: llvm-commits at cs.uiuc.edu
> Sent: Friday, April 5, 2013 1:38:09 PM
> Subject: Re: [llvm] r178845 - Fix bug in PEI's virtual-register scavenging
> 
> On 4/5/2013 1:01 PM, Krzysztof Parzyszek wrote:
> > They key thing is to tell the
> > scavenger about the kills in the instruction which formerly had
> > virtual
> > registers.
> 
> Brainfart.  The kills won't happen in the same instruction as the def
> (and the def is the point at which scavenging happens).  Sorry, it's
> been a while since I looked at it (20-something hours.. haha).
> 
> I have a local fix for this and all I did was skip both the spill and
> the instruction that triggered the scavenging (after doing the
> splice).

I think that it is better to keep the RS as consistent as possible. If we ever remove the FIXME in RS and it starts verifying defs as well, this way it won't blow up.

 -Hal

> 
> -Krzysztof
> 
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by The Linux Foundation
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>