[llvm] r178854 - Buildbot fix for r178851: mistake was in wrong TargetRegisterInfo::getRegClass usage.
Jakob Stoklund Olesen
stoklund at 2pi.dk
Fri Apr 5 11:38:56 PDT 2013
On Apr 5, 2013, at 11:36 AM, Renato Golin <renato.golin at linaro.org> wrote:
> On 5 April 2013 19:26, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:
>
> That's not right either. How are you testing this code? Please don't just guess.
>
> You should probably be using QPRRegClass.contains().
>
> Hi Jacob,
>
> I have reverted this (and the original) patch already. This is not right and there isn't enough tests to make me sleep at night.
>
> Unless I see clear evidence that a patch in that area is actually doing what it should (via review of someone that knows it, like you) AND proper tests are passing (including the test-suite on ARM), it'll remain reverted.
Thanks, Renato.
I agree.
/jakob
More information about the llvm-commits
mailing list