[llvm] r178854 - Buildbot fix for r178851: mistake was in wrong TargetRegisterInfo::getRegClass usage.
Jakob Stoklund Olesen
stoklund at 2pi.dk
Fri Apr 5 11:26:20 PDT 2013
On Apr 5, 2013, at 12:34 AM, Stepan Dyatkovskiy <stpworld at narod.ru> wrote:
> Author: dyatkovskiy
> Date: Fri Apr 5 02:34:08 2013
> New Revision: 178854
>
> URL: http://llvm.org/viewvc/llvm-project?rev=178854&view=rev
> Log:
> Buildbot fix for r178851: mistake was in wrong TargetRegisterInfo::getRegClass usage.
>
> Modified:
> llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp
>
> Modified: llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp
> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp?rev=178854&r1=178853&r2=178854&view=diff
> ==============================================================================
> --- llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp (original)
> +++ llvm/trunk/lib/Target/ARM/ARMLoadStoreOptimizer.cpp Fri Apr 5 02:34:08 2013
> @@ -103,7 +103,7 @@ namespace {
> SmallVector<unsigned, 4> getUnitRegs(unsigned Reg) {
> SmallVector<unsigned, 4> Res;
>
> - const TargetRegisterClass* TRC = TRI->getRegClass(Reg);
> + const TargetRegisterClass* TRC = TRI->getMinimalPhysRegClass(Reg);
> if (TRC == &ARM::QPRRegClass) {
> if (Reg > ARM::Q7) {
> Res.push_back(TRI->getSubReg(Reg, ARM::dsub_0));
That's not right either. How are you testing this code? Please don't just guess.
You should probably be using QPRRegClass.contains().
/jakob
More information about the llvm-commits
mailing list