[llvm] r178058 - Update PEI's virtual-register-based scavenging to support multiple simultaneous mappings

[Pranav Bhandarkar]

On 4/4/2013 5:00 PM, Hal Finkel wrote:
> Pranav,
>
> I've attached a potential fix for this problem. Can you please test it and let me know what you think?

Hal,
Thanks, this patch does actually fix the problem. Thanks for fixing this !

> Thanks again,
> Hal
>
> P.S. Your test case does not seem to crash with a trunk llc. I've not tried rolling back to your exact specified revision (yet) [which I suppose was r178546, right?].

I have no idea why this is so. Perhaps, I was using an already bad llc 
and not trunk llc. But I patched our internal (failing) tree with this 
patch and it fixed the problem.

Thanks again,
Pranav
>
> ----- Original Message -----
>> From: "Pranav Bhandarkar" <pranavb at codeaurora.org>
>> To: "Hal Finkel" <hfinkel at anl.gov>
>> Cc: llvm-commits at cs.uiuc.edu
>> Sent: Tuesday, April 2, 2013 7:45:55 PM
>> Subject: Re: [llvm] r178058 - Update PEI's virtual-register-based scavenging to support multiple simultaneous
>> mappings
>>
>>>> Hi Hal,
>>>>
>>>> Here is a reduced testcase.
>>>>
>>>> llc -O3 -mcpu=hexagonv5r regscavengerbug.ll
>>> Great, thanks! I'll work on fixing the problem.
>>>
>>>    -Hal
>> I just noticed a typo in a previous email. It should be
>> "-mcpu=hexagonv5" and not "hexagonv5r".
>>
>> Thanks,
>> Pranav
>>
>> --
>> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
>> hosted by The Linux Foundation
>>
>>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation