[llvm] r178679 - Implements low-level object file format specific output for COFF and

[Nico Rieck]

On 05.04.2013 03:43, Brendan Kirby wrote:
> It looks like the "LLVM :: tools__llvm-readobj__sections.test" and "LLVM
> :: tools__llvm-readobj__sections-ext.test" tests for MACHO have started
> failing after r178688 on MIPS. [...]
> /scratch/bb-slaves/mipsswbrd002/llvm-mips-linux/llvm/test/tools/llvm-readobj/sections.test:82:13:
> error: expected string not found in input
> MACHO-NEXT: Name: __text (5F 5F 74 65 78 74 00 00 00 00 00 00 00 00 00 00)
>              ^
> <stdin>:9:2: note: scanning from here
>   Name: __text (5F 5F 74 65 78 74 00 00 00 00 00 00 00 59 E4 60)
>   ^
> --
>
> Notice that the last three bytes are not zeros.  Can the output for
> llvm-readobj be changed to fix this?

I think the output is okay, but it might be unnecessary or impossible to 
test the raw buffer value in this case. For now the test should just 
check the name and skip the bytes. Support for MachO in llvm-readobj is 
experimental and incomplete, anyway.

Are these random bytes just stale memory? What about this failure?

 
http://lab.llvm.org:8011/builders/clang-ppc64-elf-linux2/builds/3939/steps/check-all_1/logs/LLVM%20%3A%3A%20tools__llvm-readobj__sections.test


-Nico