[PATCH] Fix StopTheWorld includes on Android.

Evgeniy Stepanov eugenis at google.com
Wed Apr 3 01:06:18 PDT 2013



================
Comment at: lib/sanitizer_common/sanitizer_stoptheworld_linux.cc:354
@@ +353,3 @@
+#if defined SANITIZER_ANDROID && defined __arm__
+typedef pt_regs regs_struct;
+#else
----------------
Sounds like this may be true for any linux/arm, not just android?

================
Comment at: lib/sanitizer_common/sanitizer_stoptheworld_linux.cc:371
@@ -360,1 +370,3 @@
+    *sp = regs.ARM_sp;
+#elif __WORDSIZE == 32
     *sp = regs.esp;
----------------
Alexey Samsonov wrote:
> SANITIZER_WORDSIZE
I'd check for __x86_64__ and __i386__ instead. You are using register names specific to that platform anyway.


http://llvm-reviews.chandlerc.com/D612

BRANCH
  stw-regs-android-fix

ARCANIST PROJECT
  compiler-rt



More information about the llvm-commits mailing list