Fix for PR14824: Optimization arm_ldst_opt inserts newly generated instruction vldmia at incorrect position

Stepan Dyatkovskiy stpworld at narod.ru
Tue Apr 2 22:29:06 PDT 2013


Hello Renato,
Thanks. I'll run test-suite today, if everything would fine, I commit it 
then.

-Stepan.

Renato Golin wrote:
> On 27 March 2013 12:50, Stepan Dyatkovskiy <stpworld at narod.ru
> <mailto:stpworld at narod.ru>> wrote:
>
>     Hello guys,
>     Well I introduced unit-regs-in-use set, and reg-to-unit-regs map.
>     Now each time we add load operation it just resolves unit-regs
>     affected and checks case when new operation overrides some previous one.
>     If I detect the "override" fact, well I scan all previous load
>     operations and remove ones were overridden.
>
>
> Hi Stepan,
>
> Sorry for the delay, but the patch looks good as far as I can tell in
> this early morning review. ;)
>
> If no one else objects, and you ran all appropriate tests (including
> check-all and possibly the test-suite on at least one platform), I'm ok
> with it.
>
> cheers,
> --renato




More information about the llvm-commits mailing list