Looks good. ================ Comment at: utils/yaml2obj/yaml2obj.cpp:420-423 @@ +419,6 @@ +namespace llvm { + namespace yaml { +#define ECase(X) IO.enumCase(Value, #X, COFF::X); + + template <> + struct ScalarEnumerationTraits<COFF::SymbolComplexType> { ---------------- This shouldn't be indented. http://llvm-reviews.chandlerc.com/D610