[llvm] r178368 - Hexagon: Add emitFrameIndexDebugValue function to emit debug information.

[Eric Christopher]

When you split it out as we discussed in the other thread we should
have a decent backend test for this.

-eric

On Mon, Apr 1, 2013 at 10:07 AM, Jyotsna Verma <jverma at codeaurora.org> wrote:
>>I will add a test for this change.
>
> Actually, there is an existing test for this fix.
> clang/test/CodeGenCXX/debug-info-byval.cpp fails for Hexagon without this
> change.
>
> Thanks,
> Jyotsna
>
>
>>Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted
>>by The Linux Foundation
>>
>>
>>>-----Original Message-----
>>>From: Rafael Ávila De Espíndola [mailto:rafael.espindola at gmail.com]
>>>Sent: Monday, April 01, 2013 10:52 AM
>>>To: Jyotsna Verma
>>>Cc: llvm-commits at cs.uiuc.edu
>>>Subject: Re: [llvm] r178368 - Hexagon: Add emitFrameIndexDebugValue
>>>function to emit debug information.
>>>
>>>Test case?
>>>
>>>Sent from my iPhone
>>>
>>>On 2013-03-29, at 17:09, Jyotsna Verma <jverma at codeaurora.org> wrote:
>>>
>>>> Author: jverma
>>>> Date: Fri Mar 29 16:09:53 2013
>>>> New Revision: 178368
>>>>
>>>> URL: http://llvm.org/viewvc/llvm-project?rev=178368&view=rev
>>>> Log:
>>>> Hexagon: Add emitFrameIndexDebugValue function to emit debug
>>>information.
>>>>
>>>>
>>>> Modified:
>>>>    llvm/trunk/lib/Target/Hexagon/HexagonInstrInfo.cpp
>>>>    llvm/trunk/lib/Target/Hexagon/HexagonInstrInfo.h
>>>>
>>>> Modified: llvm/trunk/lib/Target/Hexagon/HexagonInstrInfo.cpp
>>>> URL: http://llvm.org/viewvc/llvm-
>>>project/llvm/trunk/lib/Target/Hexagon/HexagonInstrInfo.cpp?rev=178368&
>>r
>>>1=178367&r2=178368&view=diff
>>>>
>>>==========================================================
>>=
>>>===================
>>>> --- llvm/trunk/lib/Target/Hexagon/HexagonInstrInfo.cpp (original)
>>>> +++ llvm/trunk/lib/Target/Hexagon/HexagonInstrInfo.cpp Fri Mar 29
>>>16:09:53 2013
>>>> @@ -537,6 +537,15 @@ MachineInstr *HexagonInstrInfo::foldMemo
>>>>   return(0);
>>>> }
>>>>
>>>> +MachineInstr*
>>>> +HexagonInstrInfo::emitFrameIndexDebugValue(MachineFunction &MF,
>>>> +                                           int FrameIx, uint64_t
> Offset,
>>>> +                                           const MDNode *MDPtr,
>>>> +                                           DebugLoc DL) const {
>>>> +  MachineInstrBuilder MIB = BuildMI(MF, DL, get(Hexagon::DBG_VALUE))
>>>> +    .addImm(0).addImm(Offset).addMetadata(MDPtr);
>>>> +  return &*MIB;
>>>> +}
>>>>
>>>> unsigned HexagonInstrInfo::createVR(MachineFunction* MF, MVT VT)
>>>const {
>>>>
>>>>
>>>> Modified: llvm/trunk/lib/Target/Hexagon/HexagonInstrInfo.h
>>>> URL: http://llvm.org/viewvc/llvm-
>>>project/llvm/trunk/lib/Target/Hexagon/HexagonInstrInfo.h?rev=178368&r1
>>=
>>>178367&r2=178368&view=diff
>>>>
>>>==========================================================
>>=
>>>===================
>>>> --- llvm/trunk/lib/Target/Hexagon/HexagonInstrInfo.h (original)
>>>> +++ llvm/trunk/lib/Target/Hexagon/HexagonInstrInfo.h Fri Mar 29
>>>> +++ 16:09:53
>>>2013
>>>> @@ -141,6 +141,11 @@ public:
>>>>   isProfitableToDupForIfCvt(MachineBasicBlock &MBB,unsigned
>>NumCycles,
>>>>                             const BranchProbability &Probability)
>>>> const;
>>>>
>>>> +  virtual MachineInstr *emitFrameIndexDebugValue(MachineFunction
>>>&MF,
>>>> +                                                 int FrameIx,
>>>> +                                                 uint64_t Offset,
>>>> +                                                 const MDNode *MDPtr,
>>>> +                                                 DebugLoc DL) const;
>>>>   virtual DFAPacketizer*
>>>>   CreateTargetScheduleState(const TargetMachine *TM,
>>>>                             const ScheduleDAG *DAG) const;
>>>>
>>>>
>>>> _______________________________________________
>>>> llvm-commits mailing list
>>>> llvm-commits at cs.uiuc.edu
>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits