[llvm] r178459 - X86TTI: Add accurate costs for itofp operations, based on the actual instruction counts.

Nadav Rotem nrotem at apple.com
Mon Apr 1 08:48:13 PDT 2013


I think that the tables need to be only for legal types, because we perform type-legalization before we check for the cost.  So, we don't need 8xi8, 8xi1, 4xi1, etc. 


On Apr 1, 2013, at 6:50 AM, Arnold Schwaighofer <aschwaighofer at apple.com> wrote:

> Thanks Ben. Very much appreciated!
> 
> On Apr 1, 2013, at 5:23 AM, Benjamin Kramer <benny.kra at googlemail.com> wrote:
> 
>> Author: d0k
>> Date: Mon Apr  1 05:23:49 2013
>> New Revision: 178459
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=178459&view=rev
>> Log:
>> X86TTI: Add accurate costs for itofp operations, based on the actual instruction counts.
>> 
>> Modified:
>>   llvm/trunk/lib/Target/X86/X86TargetTransformInfo.cpp
>>   llvm/trunk/test/Analysis/CostModel/X86/cast.ll
>>   llvm/trunk/test/Transforms/LoopVectorize/X86/conversion-cost.ll
>> 
>> Modified: llvm/trunk/lib/Target/X86/X86TargetTransformInfo.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86TargetTransformInfo.cpp?rev=178459&r1=178458&r2=178459&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/Target/X86/X86TargetTransformInfo.cpp (original)
>> +++ llvm/trunk/lib/Target/X86/X86TargetTransformInfo.cpp Mon Apr  1 05:23:49 2013
>> @@ -271,10 +271,33 @@ unsigned X86TTI::getCastInstrCost(unsign
>>    { ISD::ZERO_EXTEND, MVT::v4i64, MVT::v4i32, 1 },
>>    { ISD::TRUNCATE,    MVT::v4i32, MVT::v4i64, 1 },
>>    { ISD::TRUNCATE,    MVT::v8i16, MVT::v8i32, 1 },
>> -    { ISD::SINT_TO_FP,  MVT::v8f32, MVT::v8i8,  1 },
>> -    { ISD::SINT_TO_FP,  MVT::v4f32, MVT::v4i8,  1 },
>> -    { ISD::UINT_TO_FP,  MVT::v8f32, MVT::v8i8,  1 },
>> -    { ISD::UINT_TO_FP,  MVT::v4f32, MVT::v4i8,  1 },
>> +
>> +    { ISD::SINT_TO_FP,  MVT::v8f32, MVT::v8i1,  8 },
>> +    { ISD::SINT_TO_FP,  MVT::v8f32, MVT::v8i8,  8 },
>> +    { ISD::SINT_TO_FP,  MVT::v8f32, MVT::v8i16, 5 },
>> +    { ISD::SINT_TO_FP,  MVT::v8f32, MVT::v8i32, 1 },
>> +    { ISD::SINT_TO_FP,  MVT::v4f32, MVT::v4i1,  3 },
>> +    { ISD::SINT_TO_FP,  MVT::v4f32, MVT::v4i8,  3 },
>> +    { ISD::SINT_TO_FP,  MVT::v4f32, MVT::v4i16, 3 },
>> +    { ISD::SINT_TO_FP,  MVT::v4f32, MVT::v4i32, 1 },
>> +    { ISD::SINT_TO_FP,  MVT::v4f64, MVT::v4i1,  3 },
>> +    { ISD::SINT_TO_FP,  MVT::v4f64, MVT::v4i8,  3 },
>> +    { ISD::SINT_TO_FP,  MVT::v4f64, MVT::v4i16, 3 },
>> +    { ISD::SINT_TO_FP,  MVT::v4f64, MVT::v4i32, 1 },
>> +
>> +    { ISD::UINT_TO_FP,  MVT::v8f32, MVT::v8i1,  6 },
>> +    { ISD::UINT_TO_FP,  MVT::v8f32, MVT::v8i8,  5 },
>> +    { ISD::UINT_TO_FP,  MVT::v8f32, MVT::v8i16, 5 },
>> +    { ISD::UINT_TO_FP,  MVT::v8f32, MVT::v8i32, 9 },
>> +    { ISD::UINT_TO_FP,  MVT::v4f32, MVT::v4i1,  7 },
>> +    { ISD::UINT_TO_FP,  MVT::v4f32, MVT::v4i8,  2 },
>> +    { ISD::UINT_TO_FP,  MVT::v4f32, MVT::v4i16, 2 },
>> +    { ISD::UINT_TO_FP,  MVT::v4f32, MVT::v4i32, 6 },
>> +    { ISD::UINT_TO_FP,  MVT::v4f64, MVT::v4i1,  7 },
>> +    { ISD::UINT_TO_FP,  MVT::v4f64, MVT::v4i8,  2 },
>> +    { ISD::UINT_TO_FP,  MVT::v4f64, MVT::v4i16, 2 },
>> +    { ISD::UINT_TO_FP,  MVT::v4f64, MVT::v4i32, 6 },
>> +
>>    { ISD::FP_TO_SINT,  MVT::v8i8,  MVT::v8f32, 1 },
>>    { ISD::FP_TO_SINT,  MVT::v4i8,  MVT::v4f32, 1 },
>>    { ISD::ZERO_EXTEND, MVT::v8i32, MVT::v8i1,  6 },
>> 
>> Modified: llvm/trunk/test/Analysis/CostModel/X86/cast.ll
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/Analysis/CostModel/X86/cast.ll?rev=178459&r1=178458&r2=178459&view=diff
>> ==============================================================================
>> --- llvm/trunk/test/Analysis/CostModel/X86/cast.ll (original)
>> +++ llvm/trunk/test/Analysis/CostModel/X86/cast.ll Mon Apr  1 05:23:49 2013
>> @@ -77,3 +77,78 @@ define i32 @masks4(<4 x i1> %in) {
>>  ret i32 undef
>> }
>> 
>> +define void @sitofp4(<4 x i1> %a, <4 x i8> %b, <4 x i16> %c, <4 x i32> %d) {
>> +  ; CHECK: cost of 3 {{.*}} sitofp
>> +  %A1 = sitofp <4 x i1> %a to <4 x float>
>> +  ; CHECK: cost of 3 {{.*}} sitofp
>> +  %A2 = sitofp <4 x i1> %a to <4 x double>
>> +
>> +  ; CHECK: cost of 3 {{.*}} sitofp
>> +  %B1 = sitofp <4 x i8> %b to <4 x float>
>> +  ; CHECK: cost of 3 {{.*}} sitofp
>> +  %B2 = sitofp <4 x i8> %b to <4 x double>
>> +
>> +  ; CHECK: cost of 3 {{.*}} sitofp
>> +  %C1 = sitofp <4 x i16> %c to <4 x float>
>> +  ; CHECK: cost of 3 {{.*}} sitofp
>> +  %C2 = sitofp <4 x i16> %c to <4 x double>
>> +
>> +  ; CHECK: cost of 1 {{.*}} sitofp
>> +  %D1 = sitofp <4 x i32> %d to <4 x float>
>> +  ; CHECK: cost of 1 {{.*}} sitofp
>> +  %D2 = sitofp <4 x i32> %d to <4 x double>
>> +  ret void
>> +}
>> +
>> +define void @sitofp8(<8 x i1> %a, <8 x i8> %b, <8 x i16> %c, <8 x i32> %d) {
>> +  ; CHECK: cost of 8 {{.*}} sitofp
>> +  %A1 = sitofp <8 x i1> %a to <8 x float>
>> +
>> +  ; CHECK: cost of 8 {{.*}} sitofp
>> +  %B1 = sitofp <8 x i8> %b to <8 x float>
>> +
>> +  ; CHECK: cost of 5 {{.*}} sitofp
>> +  %C1 = sitofp <8 x i16> %c to <8 x float>
>> +
>> +  ; CHECK: cost of 1 {{.*}} sitofp
>> +  %D1 = sitofp <8 x i32> %d to <8 x float>
>> +  ret void
>> +}
>> +
>> +define void @uitofp4(<4 x i1> %a, <4 x i8> %b, <4 x i16> %c, <4 x i32> %d) {
>> +  ; CHECK: cost of 7 {{.*}} uitofp
>> +  %A1 = uitofp <4 x i1> %a to <4 x float>
>> +  ; CHECK: cost of 7 {{.*}} uitofp
>> +  %A2 = uitofp <4 x i1> %a to <4 x double>
>> +
>> +  ; CHECK: cost of 2 {{.*}} uitofp
>> +  %B1 = uitofp <4 x i8> %b to <4 x float>
>> +  ; CHECK: cost of 2 {{.*}} uitofp
>> +  %B2 = uitofp <4 x i8> %b to <4 x double>
>> +
>> +  ; CHECK: cost of 2 {{.*}} uitofp
>> +  %C1 = uitofp <4 x i16> %c to <4 x float>
>> +  ; CHECK: cost of 2 {{.*}} uitofp
>> +  %C2 = uitofp <4 x i16> %c to <4 x double>
>> +
>> +  ; CHECK: cost of 6 {{.*}} uitofp
>> +  %D1 = uitofp <4 x i32> %d to <4 x float>
>> +  ; CHECK: cost of 6 {{.*}} uitofp
>> +  %D2 = uitofp <4 x i32> %d to <4 x double>
>> +  ret void
>> +}
>> +
>> +define void @uitofp8(<8 x i1> %a, <8 x i8> %b, <8 x i16> %c, <8 x i32> %d) {
>> +  ; CHECK: cost of 6 {{.*}} uitofp
>> +  %A1 = uitofp <8 x i1> %a to <8 x float>
>> +
>> +  ; CHECK: cost of 5 {{.*}} uitofp
>> +  %B1 = uitofp <8 x i8> %b to <8 x float>
>> +
>> +  ; CHECK: cost of 5 {{.*}} uitofp
>> +  %C1 = uitofp <8 x i16> %c to <8 x float>
>> +
>> +  ; CHECK: cost of 9 {{.*}} uitofp
>> +  %D1 = uitofp <8 x i32> %d to <8 x float>
>> +  ret void
>> +}
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130401/6a8745d3/attachment.html>


More information about the llvm-commits mailing list