[PATCH] Add register dumping support to SuspendedThreadsList.

[Alexander Potapenko]

Ok, this is convincing. LGTM
On Mar 29, 2013 10:36 PM, "Sergey Matveev" <earthdok at google.com> wrote:

>
>   > can you use sizeof(user_regs_struct) instead of RegisterCount()?
>
>   Since we're passing an array of uptrs, I think it makes more sense to
> talk in terms of array's length rather than its size in bytes. But I can
> change that if it's bothering you.
>
>   > why do you need to extract SP separately here?
>
>   Because LSan needs to know the stack pointer (to distinguish between
> live and stale stack regions) but can't know its index in the array.
>
>   I guess we could make a convention to put it at index 0, but explicit is
> better than implicit, right?
>
>   Also, if we decided to filter out some registers like you suggest, the
> array wouldn't contain the SP anymore (since it doesn't normally point into
> heap).
>
> http://llvm-reviews.chandlerc.com/D593
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130329/17090ff6/attachment.html>