[PATCH] LNT ARM sqlite3

[Daniel Dunbar]

On Thu, Mar 28, 2013 at 12:57 PM, Renato Golin <rengolin at systemcall.org>wrote:

> On 28 March 2013 19:36, Daniel Dunbar <daniel at zuster.org> wrote:
> > I don't understand this comment.
>
> I thought you meant change the input to something that would be
> stable, ignore me.
>
>
> > I just meant transforming the call to qsort
> > so the sort would be stable, regardless of the actual sort implantation,
> by
> > augmenting the comparator function with the index of the element in the
> > incoming array (to disambiguate equality). See also
> > http://en.wikipedia.org/wiki/Schwartzian_transform
>
> I did that, and made no difference. Either because the current order
> is just right (and the old wrong, but I can't test it), or because it
> was never hit and the stability of the sort wasn't the one to blame,
> but the order in the indexed array.
>

My guess is because the old one is "wrong". I tried switching the code to
use mergesort (which is stable on OS X) and the output no longer matches
the current reference output. Feel free to check in the change to the code
to make it stable and the new reference output file, and if it happens to
not work on OS X I can investigate.

 - Daniel


> Since those cases were also happening on Intel, I haven't spent that
> much time on those and left them for later...
>
>
> > If I get some time to look at this I'll just find a Linux environment to
> use
> > to investigate, which should cover all the issues except for the sqlite3
> > one.
>
> That's ok, I hope the sqlite3 issue can be solved with the round()
> function.
>
> I'll update you on my progress, so that we don't work on the same
> thing at the same time.
>
> cheers,
> --renato
>
> PS: the fpcmp bug: http://llvm.org/bugs/show_bug.cgi?id=15620
>
> It's possible that sqlite3 can be fixed *only* by fixing that... I'll wait
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130328/893a752c/attachment.html>