[PATCH] [lld][ELF] Dynamic library support
Shankar Kalpathi Easwaran
shankarke at gmail.com
Thu Mar 28 17:41:10 PDT 2013
================
Comment at: lib/ReaderWriter/ELF/SectionChunks.h:836
@@ +835,3 @@
+ if (!ste._atom)
+ _hashTable->addSymbol("", index);
+ else
----------------
Michael Spencer wrote:
> When does this ever happen?
For the first undefined symbol.
================
Comment at: lib/ReaderWriter/ELF/SectionChunks.h:634
@@ -624,3 +633,3 @@
- virtual void finalize();
+ virtual void finalize(bool do_sort = true);
----------------
Michael Spencer wrote:
> doSort, or just sort.
Will make the change.
http://llvm-reviews.chandlerc.com/D587
More information about the llvm-commits
mailing list