[patch] DW_TAG_imported_module support
Eric Christopher
echristo at gmail.com
Wed Mar 27 18:41:11 PDT 2013
Sure that looks reasonable. Might want to add a comment that we need the
imported modules bit to run last since it depends on the entire compile
unit die being constructed first.
And tests. But you knew that :)
-eric
On Wed, Mar 27, 2013 at 4:24 PM, David Blaikie <dblaikie at gmail.com> wrote:
> Based on our IRC conversation this morning I've worked up the basics
> of DW_TAG_imported_module support by using a CU-level list rather than
> one list per scope. While this still has a few rough edges
> (DIImportedModule should expand to include file/line information as
> well to be consistent with GCC, and my Clang changes (not attached
> here) don't seem to account for global using directives but they work
> for function local ones).
>
> Does this seem about right? Better/worse/indifferent compared to
> per-scope lists? (seems better to me, at least)
>
> If so, I'll revert r178099 (which added the extra field to every
> DIScope with the intent that that would contain the list of
> DIImportedModules for each scope) & continue down this path.
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130327/1f98fca5/attachment.html>
More information about the llvm-commits
mailing list