[PATCH] Call Type::isVectorTy() before calling Type::getVectorNumElements

Akira Hatanaka ahatanak at gmail.com
Wed Mar 27 18:31:39 PDT 2013


Commited r178208.

Thank you for the review.

On Wed, Mar 27, 2013 at 5:53 PM, Nadav Rotem <nrotem at apple.com> wrote:

> The change looks okay.  Can you please format the patch and the test case
> in a single file and use the FileCheck tool for testing the test case ?
>
> Thanks,
> Nadav
>
>
> On 03/27/13, *Akira Hatanaka * <ahatanak at gmail.com> wrote:
>
> The attached patch adds code in InstCombiner::FoldSelectOpOp that checks
> if a Type is a vector before calling function Type::getVectorNumElements.
> Without this fix, the following command asserts:
>
> $ opt instcombine1.ll -o instcombine1.bc -O3
>
> Please review.
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130327/36761f67/attachment.html>


More information about the llvm-commits mailing list