[PATCH] llvm-readobj: COFF/ELF-specific low-level output

Eric Christopher echristo at gmail.com
Tue Mar 26 18:52:39 PDT 2013


On Tue, Mar 26, 2013 at 5:09 PM, Nico Rieck <nico.rieck at gmail.com> wrote:

>
>   You mean the four spaces indentation? The first argument doesn't fit in
> the same line. I've looked through llvm and found several different styles
> for such a case, and this seemed to be the most readable.
>
>
Yeah, but I hate those occurrences as well. :)


>   Regarding object file constants, the dumpers only define textual
> representations for existing constants. And I don't think those should be
> put into libObject.


Sure. I'm not sure it isn't useful given that multiple things may want to
have textual representations for constants, but I assuredly wasn't going to
hold up the patch for it.

-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130326/95275d3d/attachment.html>


More information about the llvm-commits mailing list