[PATCH] llvm-readobj: COFF/ELF-specific low-level output

Eric Christopher echristo at gmail.com
Tue Mar 26 12:57:01 PDT 2013


  Some of the formatting is a bit weird, but in general the patch looks fine and we can clean up other stuff after. Great looking work.

  Thoughts on getting some of the object file constants into a library (libObject perhaps) into llvm instead of putting the various specific dumpers?


================
Comment at: tools/llvm-readobj/COFFDumper.cpp:476
@@ +475,3 @@
+// by the symbol.
+error_code COFFDumper::getSectionContents(
+    const std::vector<RelocationRef> &Rels, uint64_t Offset,
----------------
Formatting is a bit weird here and in some similar cases.


http://llvm-reviews.chandlerc.com/D416

BRANCH
  readobj

ARCANIST PROJECT
  llvm



More information about the llvm-commits mailing list