[LLVMdev] Problems with 64-bit register operands of inline asm on ARM

[Kristof Beyls]

Hi Renato, Weiming,

 

I’m afraid I don’t know too much about inline assembly details, so can’t
really do a good code review.

That being said, I agree with Renato that there should be regression tests
added that test the changed functionality.

Apart from ensuring the functionality doesn’t get broken by accident in the
future, I find it also helps reviewers in
understanding the exact behavioural changes that are intended.

 

Thanks,

 

Kristof

 

From: Renato Golin [mailto:renato.golin at linaro.org] 
Sent: 25 March 2013 11:17
To: Zhao
Cc: Eric Christopher; Måns Rullgård; Jim Grosbach; Jakob Stoklund Olesen;
LLVM Commits; Kristof Beyls
Subject: Re: [LLVMdev] Problems with 64-bit register operands of inline asm
on ARM

 

On 14 March 2013 23:15, Weiming Zhao <weimingz at codeaurora.org> wrote:

Hi,

 

Attached is the patch to enable GPRPair for all i64 operands for ARM mode.

I let ASMPrinter to print subregs for ldm/stm and support ‘Q’ modifier.

I also extend SelectInlineAsm to support tied-def-use regs.

 

Hi Weiming,

 

It looks reasonable to me, have you ran the test-suite with it? Would also
be good to add some extra check-all tests, if possible.

 

Kristof,

 

Any issues on your side?

 

cheers,

--renato
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130326/3ae84a51/attachment.html>