[llvm] r177730 - R600: Use legacy (0 * anything = 0) MUL instructions for pow intrinsics

[Christian König]

Am 25.03.2013 18:38, schrieb Rafael Espíndola:
> On 25 March 2013 04:43, Michel Dänzer <michel.daenzer at amd.com> wrote:
>> On Son, 2013-03-24 at 13:48 -0400, Rafael Ávila De Espíndola wrote:
>>> Testcase?
>> There is test/CodeGen/R600/llvm.pow.ll.
> What I mean is: Why no testcase was modified by this patch? It is good
> practice to, when possible, to include test changes in the same commit
> that implemented the fix or added the feature.

As Michel already wrote in the commit message, it fixes two piglit tests 
and so doesn't need to be covered by any llvm tests.

While it might make sense for some low level instructions to be covered 
by llvm tests, it probably doesn't make any sense for complex behavior 
changes like this one, since they are covered pretty well by piglit.

Christian.

>
> Cheers,
> Rafael
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits