[llvm] r177695 - Revert r177543: Add timing of the IR parsing code with a new
Chandler Carruth
chandlerc at gmail.com
Thu Mar 21 19:20:34 PDT 2013
Author: chandlerc
Date: Thu Mar 21 21:20:34 2013
New Revision: 177695
URL: http://llvm.org/viewvc/llvm-project?rev=177695&view=rev
Log:
Revert r177543: Add timing of the IR parsing code with a new
-time-ir-parsing flag
This breaks the layering of the Support library. We can't add an
implementation side to IRReader because it refers directly to entities
only accessible as part of the IR, AsmParser, and BitcodeReader
libraries. It can only be used in a context where all of those libraries
will be available.
We'll need to find some other way to get this functionality, and
hopefully solve the long-standing layering problem of IRReader.h...
Removed:
llvm/trunk/lib/Support/IRReader.cpp
Modified:
llvm/trunk/include/llvm/Support/IRReader.h
llvm/trunk/lib/Support/CMakeLists.txt
Modified: llvm/trunk/include/llvm/Support/IRReader.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/Support/IRReader.h?rev=177695&r1=177694&r2=177695&view=diff
==============================================================================
--- llvm/trunk/include/llvm/Support/IRReader.h (original)
+++ llvm/trunk/include/llvm/Support/IRReader.h Thu Mar 21 21:20:34 2013
@@ -25,7 +25,6 @@
#include "llvm/Support/MemoryBuffer.h"
#include "llvm/Support/SourceMgr.h"
#include "llvm/Support/system_error.h"
-#include "llvm/Support/Timer.h"
namespace llvm {
@@ -70,10 +69,6 @@ namespace llvm {
return getLazyIRModule(File.take(), Err, Context);
}
- extern const char *TimeIRParsingGroupName;
- extern const char *TimeIRParsingName;
- extern bool TimeIRParsingIsEnabled;
-
/// If the given MemoryBuffer holds a bitcode image, return a Module
/// for it. Otherwise, attempt to parse it as LLVM Assembly and return
/// a Module for it. This function *always* takes ownership of the given
@@ -81,8 +76,6 @@ namespace llvm {
inline Module *ParseIR(MemoryBuffer *Buffer,
SMDiagnostic &Err,
LLVMContext &Context) {
- NamedRegionTimer T(TimeIRParsingName, TimeIRParsingGroupName,
- TimeIRParsingIsEnabled);
if (isBitcode((const unsigned char *)Buffer->getBufferStart(),
(const unsigned char *)Buffer->getBufferEnd())) {
std::string ErrMsg;
Modified: llvm/trunk/lib/Support/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/CMakeLists.txt?rev=177695&r1=177694&r2=177695&view=diff
==============================================================================
--- llvm/trunk/lib/Support/CMakeLists.txt (original)
+++ llvm/trunk/lib/Support/CMakeLists.txt Thu Mar 21 21:20:34 2013
@@ -27,7 +27,6 @@ add_llvm_library(LLVMSupport
IntEqClasses.cpp
IntervalMap.cpp
IntrusiveRefCntPtr.cpp
- IRReader.cpp
IsInf.cpp
IsNAN.cpp
Locale.cpp
Removed: llvm/trunk/lib/Support/IRReader.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Support/IRReader.cpp?rev=177694&view=auto
==============================================================================
--- llvm/trunk/lib/Support/IRReader.cpp (original)
+++ llvm/trunk/lib/Support/IRReader.cpp (removed)
@@ -1,21 +0,0 @@
-//===- IRReader.cpp - Reader for LLVM IR files ----------------------------===//
-//
-// The LLVM Compiler Infrastructure
-//
-// This file is distributed under the University of Illinois Open Source
-// License. See LICENSE.TXT for details.
-//
-//===----------------------------------------------------------------------===//
-
-#include "llvm/Support/CommandLine.h"
-#include "llvm/Support/IRReader.h"
-using namespace llvm;
-
-const char *llvm::TimeIRParsingGroupName = "LLVM IR Parsing";
-const char *llvm::TimeIRParsingName = "Parse IR";
-
-bool llvm::TimeIRParsingIsEnabled = false;
-static cl::opt<bool,true>
-EnableTimeIRParsing("time-ir-parsing", cl::location(TimeIRParsingIsEnabled),
- cl::desc("Measure the time IR parsing takes"));
-
More information about the llvm-commits
mailing list