[llvm] r177620 - Fix missing std::. Not sure how this compiles for anyone else.

[Jakub Staszak]

I think that he meant was: "Not sure how it USED TO work for anyone else" :-)

- Kuba

On Mar 21, 2013, at 9:29 PM, David Blaikie <dblaikie at gmail.com> wrote:

> On Wed, Mar 20, 2013 at 5:57 PM, Matt Arsenault
> <Matthew.Arsenault at amd.com> wrote:
>> Author: arsenm
>> Date: Wed Mar 20 19:57:21 2013
>> New Revision: 177620
>> 
>> URL: http://llvm.org/viewvc/llvm-project?rev=177620&view=rev
>> Log:
>> Fix missing std::. Not sure how this compiles for anyone else.
> 
> What compiler were you having trouble with?
> 
> For implementations where std::vector iterators are a type defined in
> the std namespace, these functions would be found by ADL. But that
> isn't guaranteed (eg: std::vector's iterators could be simple T*s) so
> your change is correct/appropriate so far as I can see.
> 
>> 
>> Modified:
>>    llvm/trunk/lib/CodeGen/MachineScheduler.cpp
>>    llvm/trunk/lib/DebugInfo/DWARFDebugAranges.cpp
>> 
>> Modified: llvm/trunk/lib/CodeGen/MachineScheduler.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/MachineScheduler.cpp?rev=177620&r1=177619&r2=177620&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/CodeGen/MachineScheduler.cpp (original)
>> +++ llvm/trunk/lib/CodeGen/MachineScheduler.cpp Wed Mar 20 19:57:21 2013
>> @@ -2182,7 +2182,7 @@ public:
>>   /// Callback to select the highest priority node from the ready Q.
>>   virtual SUnit *pickNode(bool &IsTopNode) {
>>     if (ReadyQ.empty()) return NULL;
>> -    pop_heap(ReadyQ.begin(), ReadyQ.end(), Cmp);
>> +    std::pop_heap(ReadyQ.begin(), ReadyQ.end(), Cmp);
>>     SUnit *SU = ReadyQ.back();
>>     ReadyQ.pop_back();
>>     IsTopNode = false;
>> 
>> Modified: llvm/trunk/lib/DebugInfo/DWARFDebugAranges.cpp
>> URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFDebugAranges.cpp?rev=177620&r1=177619&r2=177620&view=diff
>> ==============================================================================
>> --- llvm/trunk/lib/DebugInfo/DWARFDebugAranges.cpp (original)
>> +++ llvm/trunk/lib/DebugInfo/DWARFDebugAranges.cpp Wed Mar 20 19:57:21 2013
>> @@ -186,7 +186,7 @@ uint32_t DWARFDebugAranges::findAddress(
>>     Range range(address);
>>     RangeCollIterator begin = Aranges.begin();
>>     RangeCollIterator end = Aranges.end();
>> -    RangeCollIterator pos = lower_bound(begin, end, range, RangeLessThan);
>> +    RangeCollIterator pos = std::lower_bound(begin, end, range, RangeLessThan);
>> 
>>     if (pos != end && pos->LoPC <= address && address < pos->HiPC()) {
>>       return pos->Offset;
>> 
>> 
>> _______________________________________________
>> llvm-commits mailing list
>> llvm-commits at cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits