Patches for SI
Michel Dänzer
michel at daenzer.net
Thu Mar 21 07:02:47 PDT 2013
On Don, 2013-03-21 at 12:37 +0100, Christian König wrote:
>
> attached are the next bunch of improvements for the SI llvm backend.
>
> Since Tom is on vacation it's probably on us to review them ourself.
> They are stabilizing the register allocation, and so should make it
> possible to use RegPressure scheduling again without running out of
> registers in (for example) lightsmark.
Sounds good.
Patch 2 makes sense for the intrinsics loading inputs or constants, but
how is texture sampling not reading from memory? :)
For patch 3, 'switch back to RegPressure' is somewhat misleading, as we
were originally not setting any scheduling preference, and I don't think
RegPressure is the default? Also, will this tend to result in using more
GPRs? Couldn't using fewer GPRs allow dispatching more threads in
parallel in some cases?
Patch 6 is above my head I'm afraid.
The rest looks good to me.
--
Earthling Michel Dänzer | http://www.amd.com
Libre software enthusiast | Debian, X and DRI developer
More information about the llvm-commits
mailing list