[llvm] r177602 - [lit] Avoid CRLFs in bash scripts on Windows

Reid Kleckner reid at kleckner.net
Wed Mar 20 16:32:14 PDT 2013


Author: rnk
Date: Wed Mar 20 18:32:14 2013
New Revision: 177602

URL: http://llvm.org/viewvc/llvm-project?rev=177602&view=rev
Log:
[lit] Avoid CRLFs in bash scripts on Windows

Native Windows Python will do line ending translation by default, which
we don't want in bash scripts.  If we're not native Windows Python, then
'b' is ignored.

Modified:
    llvm/trunk/utils/lit/lit/TestRunner.py

Modified: llvm/trunk/utils/lit/lit/TestRunner.py
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/lit/lit/TestRunner.py?rev=177602&r1=177601&r2=177602&view=diff
==============================================================================
--- llvm/trunk/utils/lit/lit/TestRunner.py (original)
+++ llvm/trunk/utils/lit/lit/TestRunner.py Wed Mar 20 18:32:14 2013
@@ -277,7 +277,10 @@ def executeScript(test, litConfig, tmpBa
         script += '.bat'
 
     # Write script file
-    f = open(script,'w')
+    mode = 'w'
+    if litConfig.isWindows and not isWin32CMDEXE:
+      mode += 'b'  # Avoid CRLFs when writing bash scripts.
+    f = open(script, mode)
     if isWin32CMDEXE:
         f.write('\nif %ERRORLEVEL% NEQ 0 EXIT\n'.join(commands))
     else:





More information about the llvm-commits mailing list