[llvm] r177525 - Move SDNode order propagation to SDNodeOrdering, which also fixes a missed

[Justin Holewinski]

On Wed, Mar 20, 2013 at 5:20 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk>wrote:

>
> On Mar 20, 2013, at 7:51 AM, Justin Holewinski <jholewinski at nvidia.com>
> wrote:
>
> >   void add(const SDNode *Node, unsigned O) {
> > -    OrderMap[Node] = O;
> > +    unsigned OldOrder = getOrder(Node);
> > +    if (OldOrder == 0 || (OldOrder > 0 && O < OldOrder))
>
> Perhaps O is no longer a good choice for a variable name here?
>
> Also, please avoid using two hash table lookups in this function. One is
> enough. They are not as cheap as the syntax suggests.
>

Fair enough, changed in r177600.


>
> Thanks,
> /jakob
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>



-- 

Thanks,

Justin Holewinski
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20130320/9915e77c/attachment.html>