[llvm-commits] [PATCH] More changes to build LLVM with xlC 12.1 on AIX 7.1

[Rafael Espíndola]

On 31 October 2012 07:54, Kai <kai at redstar.de> wrote:
> Hi!
>
> Here are a couple more changes required for xlC:

I was going over really old email and noticed this. Sorry for not
seeing it before.

> xlc_alignoftest.diff:
> The AlignOf unittest must use GNU style __attribute()__, too.

We should probably not spread uses of

defined(__GNUC__) || defined(__IBM_ATTRIBUTES)

Can you add a HAS_GNU_ATTRIBUTES macro?

> xlc_backinserter.diff:
> xlC does not find std::copy and std::back_inserter if the namespace is
> missing.

committed.

> xlc_debuginfo.diff:
> DWARFDebugArangeSet uses Header as a (public) type name and a (private)
> member name.

committed.

> xlc_unittests.diff:
> xlC does not find the right template if a template parameter is NULL. Help
> is to provide the type. Error message is:
>
> "../llvm-git/utils/unittest/googletest/include/gtest/gtest.h", line 1318.7:
> 1540-0207 (S) No common type found for operands with type "int" and "const
> int *".

It says 'int' even when we use the macro NULL? What is it expanding to?

>
> Regards
> Kai
>

Thanks,
Rafael