[compiler-rt] r177526 - tsan: correct sizes of signal-related data structures

Alexander Potapenko glider at google.com
Wed Mar 20 08:31:51 PDT 2013


Since you're replacing one magic numbers with other ones, may I ask
for a comment next to these structures?

On Wed, Mar 20, 2013 at 6:57 PM, Dmitry Vyukov <dvyukov at google.com> wrote:
> Author: dvyukov
> Date: Wed Mar 20 09:57:28 2013
> New Revision: 177526
>
> URL: http://llvm.org/viewvc/llvm-project?rev=177526&view=rev
> Log:
> tsan: correct sizes of signal-related data structures
>
> Modified:
>     compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc
>
> Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc?rev=177526&r1=177525&r2=177526&view=diff
> ==============================================================================
> --- compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc (original)
> +++ compiler-rt/trunk/lib/tsan/rtl/tsan_interceptors.cc Wed Mar 20 09:57:28 2013
> @@ -28,18 +28,18 @@
>
>  using namespace __tsan;  // NOLINT
>
> -const int kSigCount = 128;
> +const int kSigCount = 64;
>
>  struct my_siginfo_t {
> -  int opaque[128];
> +  u64 opaque[128 / sizeof(u64)];
>  };
>
>  struct sigset_t {
> -  u64 val[1024 / 8 / sizeof(u64)];
> +  u64 val[128 / sizeof(u64)];
>  };
>
>  struct ucontext_t {
> -  uptr opaque[117];
> +  u64 opaque[936 / sizeof(u64) + 1];
>  };
>
>  extern "C" int pthread_attr_init(void *attr);
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



-- 
Alexander Potapenko
Software Engineer
Google Moscow



More information about the llvm-commits mailing list