[compiler-rt] r177262 - tsan: fix memory leak

David Blaikie dblaikie at gmail.com
Mon Mar 18 09:55:36 PDT 2013


On Mon, Mar 18, 2013 at 2:09 AM, Dmitry Vyukov <dvyukov at google.com> wrote:
> Author: dvyukov
> Date: Mon Mar 18 04:09:41 2013
> New Revision: 177262
>
> URL: http://llvm.org/viewvc/llvm-project?rev=177262&view=rev
> Log:
> tsan: fix memory leak
>
> Modified:
>     compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_thread.cc
>
> Modified: compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_thread.cc
> URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_thread.cc?rev=177262&r1=177261&r2=177262&view=diff
> ==============================================================================
> --- compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_thread.cc (original)
> +++ compiler-rt/trunk/lib/tsan/rtl/tsan_rtl_thread.cc Mon Mar 18 04:09:41 2013
> @@ -71,6 +71,7 @@ void ThreadContext::OnReset(void *arg) {
>    OnCreatedArgs *args = static_cast<OnCreatedArgs *>(arg);
>    StatInc(args->thr, StatThreadReuse);
>    sync.Reset();
> +  DestroyAndFree(dead_info);

Should this be some kind of owning/smart pointer instead?

>  }
>
>  struct OnStartedArgs {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list