[PATCH] Move estimateStackSize from ARM into MachineFunction

Hal Finkel hfinkel at anl.gov
Thu Mar 14 14:19:25 PDT 2013


----- Original Message -----
> From: "Hal Finkel" <hfinkel at anl.gov>
> To: "Tim Northover" <t.p.northover at gmail.com>
> Cc: "LLVM Commits" <llvm-commits at cs.uiuc.edu>
> Sent: Thursday, March 14, 2013 2:45:02 PM
> Subject: Re: [PATCH] Move estimateStackSize from ARM into MachineFunction
> 
> ----- Original Message -----
> > From: "Tim Northover" <t.p.northover at gmail.com>
> > To: "Hal Finkel" <hfinkel at anl.gov>
> > Cc: "LLVM Commits" <llvm-commits at cs.uiuc.edu>
> > Sent: Thursday, March 14, 2013 2:24:24 PM
> > Subject: Re: [PATCH] Move estimateStackSize from ARM into
> > MachineFunction
> > 
> > > Please review this patch which moves the estimateStackSize
> > > function from the ARM backend into MachineFunction.
> > 
> > A very good idea that I should have done myself. The changes to
> > estimateFrameSize look trivial and trivially correct to me.
> > 
> > It's a bit cheeky, but I don't suppose you could make AArch64 use
> > the
> > generic one too? Our implementation is identical to ARM's,
> > byte-for-byte.
> 
> Sure, I'll do that too.

r177111, thanks!

Renato, I've added the function to MFI instead of MF.

 -Hal

> 
> Thanks again,
> Hal
> 
> > 
> > Go for it regardless.
> > 
> > Cheers.
> > 
> > Tim.
> > 
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
> 



More information about the llvm-commits mailing list