[PATCH] Add generic ThreadRegistry class for sanitizer runtimes.

Alexey Samsonov samsonov at google.com
Thu Mar 14 06:56:30 PDT 2013


  Commited as r177074


================
Comment at: lib/sanitizer_common/CMakeLists.txt:49
@@ -48,2 +48,3 @@
   sanitizer_stacktrace.h
   sanitizer_symbolizer.h
+  sanitizer_thread_registry.h
----------------
Dmitry Vyukov wrote:
> Why is sanitizer_thread_registry.h disappeared?
Guess just forgot to upload this file

================
Comment at: lib/sanitizer_common/sanitizer_thread_registry.h:198
@@ +197,3 @@
+  // Invokes callback with a specified arg for each thread context.
+  void RunCallbackForEachThread(ThreadCallback cb, void *arg) {
+    BlockingMutexLock l(&mtx_);
----------------
Alexey Samsonov wrote:
> Dmitry Vyukov wrote:
> > it should not lock the mutex, but instead require that user has locked the mutex
> Could you point a place where you want to use a modified version?
Done


http://llvm-reviews.chandlerc.com/D530



More information about the llvm-commits mailing list