[PATCH] Windows hang with long filename

Duncan Sands baldrick at free.fr
Wed Mar 13 02:31:04 PDT 2013


Hi Paul,

On 12/03/13 22:33, Robinson, Paul wrote:
> This is basically the Windows version of r176226; it avoids a
> hang when certain issues arise with an output filename.
> We found this because Clang would hang because the output file
> pathname exceeded the Windows limit of 260 characters.
> Yes, I know the context around the fix is about creating the
> parent directory; but that's the loop where the hang occurs.
>
> Murphy consequence #1:  I could not find any LLVM tool that used
> unique_file(), only Clang uses this AFAICT.  So the test is written
> for Clang, which means it has to go in the Clang suite instead of
> the LLVM suite.

can't you write an LLVM unit test for it (see the llvm/unittests
directory)?

Ciao, Duncan.



More information about the llvm-commits mailing list