[PATCH] StopTheWorld in sanitizer_common (first commit)

Sergey Matveev earthdok at google.com
Tue Mar 12 10:15:55 PDT 2013



================
Comment at: lib/sanitizer_common/sanitizer_stoptheworld_linux.cc:62
@@ +61,3 @@
+//
+// * The following functions are safe to use because they are called either
+// before the cloned thread is spawned, or after it has exited.
----------------
Dmitry Vyukov wrote:
> I guess it's safe to use any functions before the cloned thread is spawned, or after it has exited, or only these?
Any functions. Will reword to make it more clear.

================
Comment at: lib/sanitizer_common/sanitizer_stoptheworld_linux.cc:158
@@ +157,3 @@
+    }
+    thread_lister.Reset();
+  } while (added_threads);
----------------
Dmitry Vyukov wrote:
> will it report new threads provided that you do not reopen the dirent?
Yes. I added a test for this.


http://llvm-reviews.chandlerc.com/D469



More information about the llvm-commits mailing list