[PATCH] [Support][MemoryBuffer] Use sys::fs::mapped_file_region instead of sys::Path::MapInFilePages.

Aaron Ballman aaron at aaronballman.com
Mon Mar 11 19:30:58 PDT 2013


Aside from the comments you already pointed out, patch LGTM

~Aaron

On Mon, Mar 11, 2013 at 10:11 PM, Michael Spencer <bigcheesegs at gmail.com> wrote:
>
>
> ================
> Comment at: lib/Support/MemoryBuffer.cpp:188-190
> @@ -185,4 +187,5 @@
>  namespace {
>  /// MemoryBufferMMapFile - This represents a file that was mapped in with the
>  /// sys::Path::MapInFilePages method.  When destroyed, it calls the
>  /// sys::Path::UnMapFilePages method.
> +class MemoryBufferMMapFile : public MemoryBuffer {
> ----------------
> I'll fix this comment.
>
>
> http://llvm-reviews.chandlerc.com/D528
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits



More information about the llvm-commits mailing list