[PATCH] [RFC][5/17]TILE-Gx: add register information for tilegx

[Jiong Wang]

on 2013/3/11 23:15, Anton Korobeynikov wrote:
>
> ================
> Comment at: lib/Target/Tile/TileRegisterInfo.cpp:56
> @@ +55,3 @@
> +getCalleeSavedRegs(const MachineFunction *MF) const
> +{
> +  return CSR_Tile_SaveList;
> ----------------
> Please follow the Coding Style.
>
> ================
> Comment at: lib/Target/Tile/TileRegisterInfo.td:173
> @@ +172,3 @@
> +  // Return Values and Arguments, caller saved.
> +  R0_32, R1_32, R2_32, R3_32, R4_32, R5_32, R6_32, R7_32, R8_32, R9_32,
> +  // Other caller saved.
> ----------------
> You can simplify these list a lot using sequences. See ARMInstrInfo.td for reference
>
> ================
> Comment at: lib/Target/Tile/TileRegisterInfo.cpp:61
> @@ +60,3 @@
> +const uint32_t*
> +TileRegisterInfo::getCallPreservedMask(CallingConv::ID) const
> +{
> ----------------
> Same here
>
> ================
> Comment at: lib/Target/Tile/TileRegisterInfo.cpp:130
> @@ +129,3 @@
> +
> +  if(Opc == Tile::TileFI) {
> +    DestReg = MI.getOperand(0).getReg();
> ----------------
> Same here. Space after if and so on
       Anton,

            thanks for your time to review.

            I will update the patch after the review finished.

     Regards,
     Jiong
     Tilera Corporation


>
>
> http://llvm-reviews.chandlerc.com/D515
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits