[PATCH] [msan] intercept dlopen and clear shadow for it

Reid Kleckner rnk at google.com
Mon Mar 11 09:43:12 PDT 2013



================
Comment at: lib/msan/msan_linux.cc:34
@@ +33,3 @@
+// llvm/Support/Compiler.h defines away our interface.
+#undef __msan_unpoison
+
----------------
Evgeniy Stepanov wrote:
> Reid Kleckner wrote:
> > Evgeniy Stepanov wrote:
> > > This is fragile. Future additions to Compiler.h can silently disable parts of MSan.
> > > Please move UnpoisonMappedDSO to a new .cc file, so that this include does not affect anything else.
> > Yeah, sounds good.  Moved to msan_elf.cc.  It is kind of worrying that the ELF type stuff that I use here might at some point become more than just a header dependence.  Do you think it would be better to include llvm/Support/ELF.h and use Elf64/32_[EP]hdr directly?
> Why not include <sys/elf.h> instead?
Done.  The ElfW() thing was nicer than I thought it would be.


http://llvm-reviews.chandlerc.com/D509



More information about the llvm-commits mailing list