[PATCH] <<Proposed Driver Update>>

[Michael Spencer]

  Sorry for the late reply, I've been at a conference. These changes in large are fine, but I still have a concern with not having a unified core. We loose the ability to use the same command line on a different system, as the driver may add search paths and settings based on the environment the driver is run in. It also makes lld -core pretty useless. I'm not dead set against loosing this functionality, but it needs to be worth it. The only thing we gain is having simpler option parsing code.


================
Comment at: include/lld/Core/LinkerOptions.h:124-127
@@ +123,6 @@
+
+
+
+
+
+} // namespace lld
----------------
?

================
Comment at: include/lld/Driver/Driver.h:65
@@ -47,2 +64,3 @@
 
-  virtual ~Driver();
+  static Flavor selectFlavor(std::vector<const char*> &args);
+  static Flavor strToFlavor(StringRef str);
----------------
This should be an ArrayRef<StringRef>

================
Comment at: include/lld/Driver/Driver.h:91
@@ -52,1 +90,3 @@
+private:
+  static llvm::Triple getDefaultTarget(const char *progName);
 
----------------
StringRef.

================
Comment at: lib/Driver/GnuLdDriver.cpp:1
@@ +1,2 @@
+//===- lib/Driver/GNU_ld_Driver.cpp ---------------------------------------===//
+//
----------------
Match file name.


http://llvm-reviews.chandlerc.com/D481