[PATCH] Add a case to LiveIntervalAnalysis::HandleMoveUp

Andrew Trick atrick at apple.com
Tue Mar 5 17:58:59 PST 2013


On Mar 5, 2013, at 1:09 PM, Jakob Stoklund Olesen <stoklund at 2pi.dk> wrote:

> 
> On Mar 5, 2013, at 11:20 AM, Vincent Lejeune <vljn at ovi.com> wrote:
> 
>> I reworked my patch a bit so that it now updates the read-undef flags.
>> I planned to let MachineScheduler do it however updating the flag inside HandleMove allows to spot error quickier.
>> 
>> Can you have a look at it please ? 
> 
> Did you read my previous mail about the problem with live-out values? You didn't address the problem.
> 
> Andy said he is going to add a -verify-scheduler command line option that runs the machine code verifier before and after the MI scheduler. You should have some test cases that contains multiple basic blocks, and exercise this code with -stress-scheduler and -verify-sceuduler.
> 
> You should also make sure that the LLVM nightly test suite still works for x86 with -enable-misched -verify-scheduler -stress-scheduler.

That's right. You should run all the x86 tests and at least build the ARM ones.

I'll add -verify-misched soon. Currently, we have false errors due to physcial register live ranges. I need to come up with a workaround for that.

-Andy

> I would recommend that you read the code in LiveRangeCalc.cpp to better understand how live intervals work.
> 
> /jakob
> 




More information about the llvm-commits mailing list